Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxy setting #10

Open
camlspotter opened this issue Dec 5, 2013 · 3 comments
Open

Add Proxy setting #10

camlspotter opened this issue Dec 5, 2013 · 3 comments
Assignees
Milestone

Comments

@camlspotter
Copy link
Collaborator

I need to run ocamltter inside a firewall, and a proxy setting is required.

@camlspotter
Copy link
Collaborator Author

This means many function must get an additional argument for network tweaking, and adding it as an independent argument is ... very lousy.

We have already oauth arg everywhere, so I decided to extend the type of the argument from just oauth to a handle. Currently the handle consists of the oauth and a curl handle tweaker whose type is Curl.hanlde -> unit.

I believe this is a right way to do this but put my changes in "handle" branch for now.

@camlspotter
Copy link
Collaborator Author

We have Ocamltter.curl_handle_tweak of (Curl.handle -> unit) ref so we can override it at "ocamltter" script to have a proxy setting.

@ghost ghost assigned camlspotter Dec 8, 2013
@camlspotter
Copy link
Collaborator Author

This changes the API type so we must release it with a new minor version 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant