Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation plugins shouldn't store data on the nodes #12

Open
yoel-zeldes opened this issue Dec 5, 2014 · 0 comments
Open

Navigation plugins shouldn't store data on the nodes #12

yoel-zeldes opened this issue Dec 5, 2014 · 0 comments

Comments

@yoel-zeldes
Copy link
Owner

The tree, pagination and circlepack (and maybe other plugins) associate private data related to nodes by putting them on the nodes themeselves (e.g: node.tree.x). This is nasty. Instead - put all of the data in a private map from node id to the plugin's data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant