-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constructor changes for PHP7+ compatibility #36
Comments
Yep, one of the points of that development branch is to get FX.php all clean and modernized. Things have been kinda crazy for me for a while, but I also wouldn't mind if someone(s) had time to help on this. Documentation is also getting a really nice update. |
What's the lowest version of PHP you're targeting for backward compatibility? |
There really needs to be another branch for this, as I'm still hoping to update things for people with older installs. That said, PHP 5.3 would be nice, though I could be persuaded to use an even more recent version if there were a compelling reason. |
I just tried to upgrade to PHP 7.1 and I saw the same issues with the OO class constructors. Is there any update on when a compatible FX will be available? (By the way, thank you for keeping this code for everyone). If it helps, our institution is willing to test the code. |
Okay, just created branches called |
Hi There! I apologize if I'm missing something obvious, but, is there a version of FX that works with PHP 7+? I see that there was an intent to do so, but, it's not clear from the ReadMe.md, nor the branches, that FX is PHP 7+ ready yet. Thanks! |
Dipping my toes in PHP 7, it looks like FX.php needs some changes to its function constructors to operate error-free and continue to work for future versions. I can submit some changes later, but just wanted to point it out in case someone else has the time to submit changes.
The text was updated successfully, but these errors were encountered: