Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about results in the experiment #1

Open
13015517713 opened this issue May 1, 2022 · 4 comments
Open

about results in the experiment #1

13015517713 opened this issue May 1, 2022 · 4 comments

Comments

@13015517713
Copy link
Contributor

Hey, Youngjoon. Nice code!
Did you reproduct the similar result with that paper?

@yjlee22
Copy link
Owner

yjlee22 commented May 1, 2022

Obtained similar values ​​to the results written in the paper.

@13015517713
Copy link
Contributor Author

图片
It's the result about cifar dataset in paper. Although iid, I can't reproduce this result, more than 80% acc. I just trained the model locally, but I found it's about 70% in global testset.
The cifar model (model cnn_v2 in FedShare), is the same as another project "https://github.com/AshwinRJ/Federated-Learning-PyTorch" which implements the fedavg . I also found this problem occurring in that project. Refer "AshwinRJ/Federated-Learning-PyTorch#31".
So, did you reproduce the result about cifar using model cnn_v2? I'll appreciate it if you can share your parameters.

@yjlee22
Copy link
Owner

yjlee22 commented May 14, 2022

The currently written code like the repository you mentioned cannot achieve the same performance as the paper due to the limitations of the model for the CIFAR-10 dataset. If you increase the number of parameters of cnn_v2 model, you can achieve the performance similar to or higher than that of the paper. The following parameter settings are recommended as follows:
"""
self.conv1 = nn.Conv2d(args.num_channels, 64, kernel_size = 5)
self.conv2 = nn.Conv2d(64, 64, kernel_size = 5)
self.fc1 = nn.Linear(1600, 384)
self.fc2 = nn.Linear(384, 192)
self.fc3 = nn.Linear(192, args.num_classes)
"""

@13015517713
Copy link
Contributor Author

Ok. Thanks for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants