Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract rule name and options to separate collector #683

Closed
vjik opened this issue Apr 2, 2024 · 1 comment
Closed

Extract rule name and options to separate collector #683

vjik opened this issue Apr 2, 2024 · 1 comment
Milestone
2.0

Comments

@vjik
Copy link
Member

vjik commented Apr 2, 2024 •
edited
Loading

My suggestion:

  1. Remove method RuleInterface::getName().
  2. Remove interface RuleWithOptionsInterface.
  3. Remove RulesDumper.
  4. Create new RulesConvertor that would can be configured for usage with custom rules also.

Benefits:

  • more clear rule classes;
  • it allows to move all default values to rule handlers, that allow override default values globally.
@vjik vjik added this to the 2.0 milestone Apr 2, 2024
@vjik
Copy link
Member Author

vjik commented Apr 3, 2024

Duplicate #682

@vjik vjik closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@vjik