Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container config optional in Container constructor #384

Open
vjik opened this issue Dec 15, 2024 · 5 comments
Open

Make container config optional in Container constructor #384

vjik opened this issue Dec 15, 2024 · 5 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@vjik
Copy link
Member

vjik commented Dec 15, 2024

No description provided.

@samdark
Copy link
Member

samdark commented Dec 16, 2024

What's the use case for a container without config?

@vjik
Copy link
Member Author

vjik commented Dec 16, 2024

What's the use case for a container without config?

Unlikely, container without config makes sense in application code, but this use case is found in tests: https://github.com/search?q=org%3Ayiisoft+%22new+Container%28ContainerConfig%3A%3Acreate%28%29%29%22&type=code

@samdark
Copy link
Member

samdark commented Dec 16, 2024

That doesn't look too bad to me in tests. Let's have config mandatory.

@samdark samdark closed this as completed Dec 16, 2024
@vjik
Copy link
Member Author

vjik commented Dec 16, 2024

What is the point of passing an empty configuration if the configuration is empty by default.

@samdark samdark reopened this Dec 17, 2024
@samdark
Copy link
Member

samdark commented Dec 17, 2024

Alright. It doesn't hurt.

@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

2 participants