Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flag arguments from AR methods #285

Open
Tigrov opened this issue Jan 2, 2024 · 0 comments
Open

Remove flag arguments from AR methods #285

Tigrov opened this issue Jan 2, 2024 · 0 comments

Comments

@Tigrov
Copy link
Member

Tigrov commented Jan 2, 2024 •
edited
Loading

  • ActiveRecordInterface::getOldPrimaryKey(bool $asArray = false) split to

    • getOldPrimaryKey(): mixed equals to ActiveRecordInterface::getOldPrimaryKey(false)
    • getOldPrimaryKeys(): array equals to ActiveRecordInterface::getOldPrimaryKey(true)

  • ActiveRecordInterface::getPrimaryKey(bool $asArray = false) split to

    • getPrimaryKey(): mixed equals to ActiveRecordInterface::getPrimaryKey(false)
    • getPrimaryKeys(): array equals to ActiveRecordInterface::getPrimaryKey(true)

  • BaseActiveRecord::isAttributeChanged(string $name, bool $identical = true) split to

    • isAttributeChanged(string $name) equals to BaseActiveRecord::isAttributeChanged(string $name, true)
    • isAttributeChangedEqual(string $name) equals to BaseActiveRecord::isAttributeChanged(string $name, false)

This removes extra check for these methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tigrov