Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why combine padj rather than pvalue #5

Closed
huerqiang opened this issue Apr 24, 2021 · 1 comment
Closed

Why combine padj rather than pvalue #5

huerqiang opened this issue Apr 24, 2021 · 1 comment

Comments

@huerqiang
Copy link
Contributor

Hi! I am learning your R package. I would like to consult why you choose the adjusted pvalue to combine rather than the original pvalue: https://github.com/yigbt/multiGSEA/blob/master/R/enrichment_functions.R#L156

After all, the subsequent steps will adjust the combined pvalue:

df$combined_pval <- combinePvalues( df)
df$combined_padj <- p.adjust( df$combined_pval, method = "BH")
@boll3
Copy link
Contributor

boll3 commented Apr 8, 2024

P-values are now combined by default without prior adjustment.
To reproduce the original behavior, use col_pattern = "padj" in the combinePvalues() function.
This has been effective since Bioconductor RELEASE 3.18

@boll3 boll3 closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants