Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commandline options TODOs #26

Open
5 tasks
bernt-matthias opened this issue Dec 12, 2023 · 7 comments
Open
5 tasks

Commandline options TODOs #26

bernt-matthias opened this issue Dec 12, 2023 · 7 comments

Comments

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Dec 12, 2023

  • in order to supress arguments (hidden options) help should be set to argparse.SUPPRESS NOT default
    • set useful default values
  • set required for required arguments
  • All command line arguments need a help
  • Redundant arguments, e.g. --cuda / --no_cuda, should be removed
@bernt-matthias
Copy link
Contributor Author

ping @soulios

@soulios
Copy link
Contributor

soulios commented Dec 18, 2023

Got it. I will update you as soon as I complete the changes.

@bernt-matthias
Copy link
Contributor Author

Thanks for letting me know. The most import point for me is the first, since this makes the command line nearly unusable (if you don't use json files as input). So if possible, then attack this first.

@bernt-matthias
Copy link
Contributor Author

The 2nd point might even not be solvable at all, since with json input you don't need any other argument.

@soulios
Copy link
Contributor

soulios commented Jan 3, 2024

Fixed all issues for all modes. The required flag cannot be used for the configfile or the inputfile as they should be required in an either or fashion. A manual check if the arguments are none is done for train and predict modes.

@bernt-matthias
Copy link
Contributor Author

Fixed all issues for all modes.

Wonderful. Can you open a PR?

The required flag cannot be used for the configfile or the inputfile as they should be required in an either or fashion.

You can check sys.argv if parameters are given via config file and call argparse's parse function only if not.

@soulios
Copy link
Contributor

soulios commented Jan 12, 2024

I need to fix the installations before opening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants