Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sellFYTokenPreview should return base amount, not shares amount #53

Open
marcomariscal opened this issue Aug 29, 2022 · 1 comment
Open

sellFYTokenPreview should return base amount, not shares amount #53

marcomariscal opened this issue Aug 29, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@marcomariscal
Copy link
Contributor

marcomariscal commented Aug 29, 2022 •
edited
Loading

these tests should be updated to not fail once this issue is fixed:

  • testFailForkUnit_Euler_tradePreviewsDAI04
  • testFailForkUnit_Euler_tradePreviewsUSDC04
@marcomariscal marcomariscal added the bug Something isn't working label Aug 29, 2022
@ultrasecreth
Copy link
Contributor

I fixed this issue a while ago, but of course you'll still see the issue in the L1 dec pools as they're deployed before the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ultrasecreth @marcomariscal