YPP-0094.md

Proposal

Replace Cloak for Cloak v2 on mainnet and arbitrum

Background

Cloak v2 is easier to use and maintain by keepinf isolation plans associated to a given address which will be subject to isolation. It also includes a check function to verify that a plan can be executed.

Details

Cloak v1 will have ROOT permissions removed from all contracts, and Cloak v2 will be given ROOT permissions on the same. Then isolation plans will be added for the Ladle, Witch, fyTokens, Giver and Lever, where applicable.

Here are the steps:

1. Deploy Cloak V2 (no need for governance approval)
2. Governance proposal
   1. Cloak v1 will have ROOT permissions removed from all contracts
   2. Cloak v2 will be given ROOT permissions on the same
   3. Isolation plans will be added for the Ladle, Witch, fyTokens, Giver and Lever, where applicable
   4. All plans will be tested using OnChainTest

Script that performed said actions: https://github.com/yieldprotocol/environments-v2/blob/2ef649f2e6155ae538b3f8532d0cf7d05c8871c6/scripts/governance/replace/cloakV2/replaceCloak.ts

Configuration applied (Arbitrum):

import { ContractDeployment } from '../../confTypes'

import {
  TIMELOCK,
  CLOAK,
  MULTISIG,
  CAULDRON,
  WITCH,
  LADLE,
  GIVER,
  ROLLER,
  YIELD_STRATEGY_LEVER,
  WITCH_V1,
} from '../../../../shared/constants'

import * as base_config from '../../base.arb_mainnet.config'

export const developer: string = '0xC7aE076086623ecEA2450e364C838916a043F9a8'
export const deployer: string = '0xC7aE076086623ecEA2450e364C838916a043F9a8'

export const governance: Map<string, string> = base_config.governance
export const protocol: Map<string, string> = base_config.protocol
export const assets: Map<string, string> = base_config.assets
export const joins: Map<string, string> = base_config.joins
export const fyTokens: Map<string, string> = base_config.fyTokens
export const pools: Map<string, string> = base_config.pools
export const strategies: Map<string, string> = base_config.strategies
export const external: Map<string, string> = base_config.external

// ----- deployment parameters -----
export const contractDeployments: ContractDeployment[] = [
  {
    addressFile: 'governance.json',
    name: CLOAK,
    contract: 'EmergencyBrake',
    args: [() => governance.get(MULTISIG)!, () => governance.get(TIMELOCK)!, () => developer],
  },
]

export const executors = [
  '0xC7aE076086623ecEA2450e364C838916a043F9a8', // Alberto Cuesta Cañada
  '0x06FB6f89eAA936d4Cfe58FfA071cf8EAe17ac9AB', // Prafful Sahu
  '0x9152F1f95b0819DA526BF6e0cB800559542b5b25', // James Thompson
  '0x05950b4e68f103d5aBEf20364dE219a247e59C23', // Bruno Bonnano
  '0x02f73B54ccfBA5c91bf432087D60e4b3a781E497', // Egill Hreinsson
  '0x1662BbbDdA3fb169f10C495AE27596Af7f8fD3E1', // Marco Mariscal
]

export const levers: string[] = [protocol.get(YIELD_STRATEGY_LEVER)!]

export const users: Array<string> = [protocol.getOrThrow(LADLE), protocol.getOrThrow(WITCH), protocol.getOrThrow(GIVER)]

fyTokens.forEach((value: string) => {
  users.push(value)
})

levers.forEach((element) => {
  users.push(element)
})

Configuration applied (Mainnet):

import { ContractDeployment } from '../../confTypes'

import {
  TIMELOCK,
  CLOAK,
  MULTISIG,
  CAULDRON,
  WITCH,
  LADLE,
  GIVER,
  ROLLER,
  YIELD_STRATEGY_LEVER,
  WITCH_V1,
  ONCHAINTEST,
} from '../../../../shared/constants'

import * as base_config from '../../base.mainnet.config'

export const developer: string = '0xC7aE076086623ecEA2450e364C838916a043F9a8'
export const deployer: string = '0xC7aE076086623ecEA2450e364C838916a043F9a8'

export const governance: Map<string, string> = base_config.governance
export const protocol: Map<string, string> = base_config.protocol
export const assets: Map<string, string> = base_config.assets
export const joins: Map<string, string> = base_config.joins
export const fyTokens: Map<string, string> = base_config.fyTokens
export const pools: Map<string, string> = base_config.pools
export const strategies: Map<string, string> = base_config.strategies
export const external: Map<string, string> = base_config.external

// ----- deployment parameters -----
export const contractDeployments: ContractDeployment[] = [
  {
    addressFile: 'protocol.json',
    name: ONCHAINTEST,
    contract: 'OnChainTest',
    args: [],
  },
  {
    addressFile: 'governance.json',
    name: CLOAK,
    contract: 'EmergencyBrake',
    args: [() => governance.get(MULTISIG)!, () => governance.get(TIMELOCK)!, () => developer],
  },
]

export const executors = [
  '0xC7aE076086623ecEA2450e364C838916a043F9a8', // Alberto Cuesta Cañada
  '0x06FB6f89eAA936d4Cfe58FfA071cf8EAe17ac9AB', // Prafful Sahu
  '0x9152F1f95b0819DA526BF6e0cB800559542b5b25', // James Thompson
  '0x05950b4e68f103d5aBEf20364dE219a247e59C23', // Bruno Bonnano
  '0x02f73B54ccfBA5c91bf432087D60e4b3a781E497', // Egill Hreinsson
  '0x1662BbbDdA3fb169f10C495AE27596Af7f8fD3E1', // Marco Mariscal
]

export const levers: string[] = [protocol.get(YIELD_STRATEGY_LEVER)!]

export const users: Array<string> = [protocol.getOrThrow(LADLE), protocol.getOrThrow(WITCH)]

fyTokens.forEach((value: string) => {
  users.push(value)
})

Testing

Arbitrum: Isolate ladle Restore ladle

Mainnet: Isolate ladle Restore ladle