test: Don't check for the exact size of compressed content. #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachi107
suggested changes
Nov 24, 2024
test/test.cc
Outdated
| @@ -4258,7 +4258,7 @@ TEST_F(ServerTest, PutLargeFileWithGzip2) { | |||
| ASSERT_TRUE(res); | |||
| EXPECT_EQ(StatusCode::OK_200, res->status); | |||
| EXPECT_EQ(LARGE_DATA, res->body); | |||
| EXPECT_EQ(101942u, res.get_request_header_value_u64("Content-Length")); | |||
| EXPECT_TRUE(res.get_request_header_value_u64("Content-Length") < (10 * 1024 * 1024)); | |||
There was a problem hiding this comment.
Instead of EXPECT_TRUE, it'd be better to use EXPECT_LT
There was a problem hiding this comment.
@sebastianas could you also put some comment before EXPECT_LT, so that it clearly explains why this check doesn't use EXPECT_EQ? Thanks!
There was a problem hiding this comment.
both changes have been made.
The testsuite checks for the exact size of the compressed content. The exact size can change if the zlib library is using a different strategy. In thise case using zlib-ng results in a slightly larger content leading to a failure in the test. Check that the compressed content is less than 10MiB which is a tenth of the orignal content and proves that compression works. Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
|
@sebastianas thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testsuite checks for the exact size of the compressed content. The exact size can change if the zlib library is using a different strategy. In thise case using zlib-ng results in a slightly larger content leading to a failure in the test.
Check that the compressed content is less than 10MiB which is a tenth of the orignal content and proves that compression works.