Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket upgrade? #75

Open
c-cube opened this issue Feb 12, 2024 · 2 comments
Open

websocket upgrade? #75

c-cube opened this issue Feb 12, 2024 · 2 comments

Comments

@c-cube
Copy link

c-cube commented Feb 12, 2024

I see in curl's doc that websockets are supported, but I don't see them in https://ygrek.org/p/ocurl/api/Curl.html . Is it explicitly not supported? Would it be a lot of work to add support, if there was a will?

@nojb
Copy link
Contributor

nojb commented Feb 12, 2024

I allow myself to give a first response (but of course @ygrek will give the ultimate answer). This project is basically on maintenance mode but patches to extend coverage of libcurl are received with some frequency; they are reviewed and generally accepted (as a glance at the list of closed PRs will show you). So I would say that if you are interested in adding bindings for the WebSocket functions, your best bet is to put a patch together and submit it for integration.

One issue to keep in mind is that these functions are marked "EXPERIMENTAL" which means they could change in the future. I don't know if there is any policy regarding such functions in ocurl.

@ygrek
Copy link
Owner

ygrek commented Feb 12, 2024

Yes, patches are welcome ofcourse. Experimental can just mark the same in ocaml interface and we will be free to break them in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants