-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-update: Sync exceptions in auto-update stops auto-update loops indefinitely #920
Comments
The usage of this in warp is to get the current time - which never throws an exception. So perhaps the code wasn't written |
No, it wasn't. It was designed for speed, and leaves exception handling to the called function. That's an oversight in the current documentation, PR certainly welcome to clarify that. |
I'll make a documentation PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed behaviour
When
getKeys
(ourupdateAction
) throws an exception on the second request, the request toautoUpdatingGetKeys
hangs indefinitely. Any follow-up requests fail with the following error:Expected Behaviour
Reading the source code of
auto-update
the code claims that the worker thread shouldonly be able to exit in case of an unexpected async exception (and even says that the only case
that can happen is RTS exceptions). However in this case it also exits when
updateAction
throwsa synchronous exception. This feels like a bug to me.
Reproducer
Now on terminal 1 you will see:
Versions used:
The text was updated successfully, but these errors were encountered: