-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warp: Use custom exception on listen socket closure #873
Comments
Making such a change would end up silently breaking lots of existing code that's doing exactly what you've done here. |
Hmm so options here:
Probably 1 is the right answer for the library but I wouldn't say no to 3. |
An option (4) that I think would work here: provide predicate functions that test for the common cases people care about, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, my custom uncaught exception logger needs:
in order to avoid logging the
invalid argument
error that results from the listen socket being closed (to start graceful shutdown). It would be nice to have a custom exception type passed to the uncaught exception handler in this case, as it's an internal implementation detail if there could be other cases ofResourceVanished
orInvalidArgument
thrown prior to the construction of theRequest
which we actually do want to log.The text was updated successfully, but these errors were encountered: