Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused method in the main generator file #9

Open
peterblazejewicz opened this issue Jan 22, 2015 · 2 comments
Open

Unused method in the main generator file #9

peterblazejewicz opened this issue Jan 22, 2015 · 2 comments

Comments

@peterblazejewicz
Copy link

Am I wrong or welcome method is no longer used in app.js file? (the generator does not show any Yo welcome message by itself):

https://github.com/yeoman/generator-commonjs/blob/master/app/index.js#L9-L11

@SBoudrias
Copy link
Member

welcome is actually run after prompting meaning they must just not be in order.

@peterblazejewicz
Copy link
Author

Maybe I was not clear - it prompts - but undefined:

yo commonjs
? Module Name: ...
? Description: ...
? Homepage: ...
? License: ...
? GitHub username: ...
? Author's Name: ...
? Author's Email: ..
? Author's Homepage: ..
undefined
   create package.json
   create src/.jshintrc
   create src/module.js
   create test/module_test.js

so technically it runs. The generator does not show typical Yo's welcome message - so it got me thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants