Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

这个地方逻辑有点奇怪，定义了result但是后面没有使用 #8

Closed
orikey0 opened this issue Jul 30, 2024 · 3 comments
Closed

这个地方逻辑有点奇怪，定义了result但是后面没有使用 #8

orikey0 opened this issue Jul 30, 2024 · 3 comments

Comments

@orikey0
Copy link

orikey0 commented Jul 30, 2024 •
edited
Loading 

func (s *Cmpp) DeliverResp(sequenceID uint32, msgId uint64, result uint8) error {

	op, err := protocol.NewDeliverResp(sequenceID, msgId, protocol.OK)
	if err != nil {
		return err
	}

	return s.Write(op)
}
@yedamao
Copy link
Owner

yedamao commented Aug 6, 2024

是写错了. result应该被传入 protocol.NewDeliverResp

@orikey0
Copy link
Author

orikey0 commented Aug 6, 2024

是写错了. result应该被传入 protocol.NewDeliverResp

提了一个pr #9

@yedamao
Copy link
Owner

yedamao commented Aug 7, 2024

是写错了. result应该被传入 protocol.NewDeliverResp

提了一个pr #9

Thanks

@yedamao yedamao closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yedamao @orikey0