Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Script toLocale broken #199

Open
DarkGhost7 opened this issue Mar 24, 2022 · 5 comments
Open

Script toLocale broken #199

DarkGhost7 opened this issue Mar 24, 2022 · 5 comments
Labels
good first issue Good for newcomers python

Comments

@DarkGhost7
Copy link
Contributor

DarkGhost7 commented Mar 24, 2022

Adding in non-english characters has broken the python script.
Also, I think the script changed a - to \u2013
here and in this commit eb22c11. Makes me think the script made this change.

  • Add support so it will still run and also not overwrite any committed (non-English) translations of strategy descriptions.
  • See if it has a problem with - or other non-alphabet characters.

image

@DarkGhost7 DarkGhost7 added good first issue Good for newcomers python labels Mar 24, 2022
@qosmonot
Copy link
Contributor

you also can find \u2018 replacing ' in a few locations (all?)

@faisals
Copy link

faisals commented Apr 1, 2022

Script seems to work fine for me locally.

@DarkGhost7
Copy link
Contributor Author

If you make a new json, does it add the localizations fine for you if you add a - in it? I can't seem to get it working but maybe this is a problem with my setup @faisals

@DarkGhost7
Copy link
Contributor Author

I see it changing \u2019 from ' as well

mmsardar added a commit to mmsardar/yearn-meta that referenced this issue Aug 2, 2022
save files as Unicode
@mmsardar
Copy link

mmsardar commented Aug 2, 2022

@DarkGhost7 check if this #318 fixes the problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers python
Projects
None yet
Development

No branches or pull requests

4 participants