-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Every day at 9am" stopped working in v2.0.0rc #21
Comments
Hi @bjonord Development has stalled on this, because the codebase is a bit too messy to do anything in a short time frame and other stuff gets in the way (life, plans… and bugs!) and Chronic, which Tickle depends on, keeps threatening a new release which also puts me off. As to your problem, it does seem that phrasing dropped out of the code at some point, my apologies. I'll add a spec for it in Regards, |
I've added a branch with the failing test here https://github.com/yb66/tickle/blob/issue-21-every-day-at-9am/spec/tickle_spec.rb#L443 |
I noticed that too. Very unfortunate. Have you gotten an indication of how breaking the new release will be?
Not sure when I'll get a chance to have look, possibly tomorrow afternoon as well. |
Not at all. It was on a private branch for a while, and may be public now but it's been spoken of for so long that I decided to wait. My plans for change, roughly, are to change Tickle's API, possibly into an (lazy) enumerator with a more standard ISO time response (I'd need to re-read my notes). The guts can change when Chronic changes. iain |
Started, but got pulled away on other stuff. One thing I noted, the branch above is branched from RC1 instead of RC2? |
Well spotted, for some reason I didn't have rc2. Weird. Anyway, I've fixed that. I also was sidetracked, I'll have a go at it tomorrow (I'm on Japan time). iain |
Hi @bjonord After wading through the code it seems Chronic was handling that bit of the parsing. I'm going to see if I can hack something in that works instead, it may or may not work. The Chronic rewrite doesn't handle it either. I'll let you know if I can get it to work. iain |
Not sure if this is being worked on or if the incantation is going to be dropped?
This works as before:
Let me know if I can lend a hand.
Cheers
The text was updated successfully, but these errors were encountered: