Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: do not leak cwd variable #69

Merged
merged 2 commits into from
Oct 19, 2024
Merged

docs: do not leak cwd variable #69

merged 2 commits into from
Oct 19, 2024

Conversation

glensc
Copy link
Contributor

@glensc glensc commented May 29, 2024

It's good practice for shell functions to local scope their variables

It's good practice for shell functions to local scope their variables
@sxyazi
Copy link
Member

sxyazi commented Jun 13, 2024

I'm going to close this because it still needs some work and hasn't seen any activity recently. @glensc thanks for the effort!

@sxyazi sxyazi closed this Jun 13, 2024
@sxyazi sxyazi reopened this Oct 19, 2024
@sxyazi sxyazi changed the title Update quick-start: Do not leak cwd variable docs: do not leak cwd variable Oct 19, 2024
Copy link
Member

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit 078ab9e into yazi-rs:main Oct 19, 2024
@glensc glensc deleted the patch-1 branch October 20, 2024 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants