-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make each little thing a linkable heading #30
Conversation
I like the new way of creating anchors for each command. What do you think about placing As for tables, it has some limitations and may prevent the representation of complex structures, such as the parameters of the |
I'm not sure of further separating the pages is a good idea. I've also been thinking about how to maintain that classification and I'm not entirely sure! My feeling is that if they all go under one |
Yeah this is the worst result I had considered to do that. But without sub-categories, we would lose the ability to group similar commands/options together for presentation, something like https://yazi-rs.github.io/docs/configuration/yazi#ueberzug-specific - although it is options rather than commands. How do you feel about keeping the original format and creating a separate anchor for each command? For example: <anchor>`escape`</anchor>: Cancel find, exit visual mode, clear selected, cancel filter, or cancel search. where the |
We could just do a fourth level of headings? |
The current issue is not about grouping but about the table. I just feel that having groups would be better, but I'm not sure if this feeling is suitable - it looks good now, at least better than before, since we can clearly link to a specific command through anchors. |
Maybe we can merge it first? |
Sorry what do you mean? Merge the conflicts? |
I'll merge it after resolving the conflict, but first with your approval and change it from draft status to mergeable (it feels weird to merge a draft lol) |
Well we probably should deal with the conflicts next, and I should turn the other two pages into tables... then it would be good to merge IMO. |
Don't turn them into tables yet, I might convert them back to the lists, still need to think about it some more... |
Then we shouldn't merge this yet ahah. |
That would make conflicts more difficult to address, and I really like the new anchor thing. I hope to see it become a reality soon😆 |
Alright, would you like to merge the conflicts? I always mess it up. |
Sure |
I think I've resolved all the conflicts. Would you like to give it a review? |
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
In the future you can add the suggestions to a batch and commit them all at once :) |
Co-authored-by: uncenter <[email protected]>
Yeah totally, I forgot about it ahah |
Thank you, merged! |
keymap.toml
: