Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update, improve, reorganize #26

Merged
merged 17 commits into from
Jan 11, 2024
Merged

feat: update, improve, reorganize #26

merged 17 commits into from
Jan 11, 2024

Conversation

uncenter
Copy link
Member

No description provided.

@uncenter
Copy link
Member Author

Need to find a way to mention that Yazi respects XDG_CONFIG_HOME...

@uncenter uncenter marked this pull request as ready for review January 10, 2024 13:36
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/quick-start.md Outdated Show resolved Hide resolved
@uncenter
Copy link
Member Author

Once/if this is merged, we should update https://github.com/sxyazi/yazi/wiki/Windows-Installation-Guide to link to the Windows section here. We should also move over the other wiki page.

docs/install.md Outdated Show resolved Hide resolved
@uncenter
Copy link
Member Author

How should I phrase it?
What we have now is:

To override any of the defaults, begin by copying the appropriate file (from the directory linked above) to either:

  • ~/.config/yazi/ on Unix/Unix-like systems.
  • C:\Users\USERNAME\AppData\Roaming\yazi\config\ on Windows.

This doesn't really work though IMO:

To override any of the defaults, begin by copying the appropriate file (from the directory linked above) to the following location:

  • Unix/Unix-like: ~/.config/yazi/
  • Windows: C:\Users\USERNAME\AppData\Roaming\yazi\config\

@sxyazi
Copy link
Member

sxyazi commented Jan 11, 2024

This doesn't really work though IMO:

Why isn't it working? Let me know your thoughts

@uncenter
Copy link
Member Author

Hmm. I think my issue is that you kinda need to say "on Windows" and "on Unix/Unix-like systems" rather than just the OS name for it to be flow logically.

@uncenter uncenter changed the title feat: clarify and restructure pages feat: update, improve, reorganize Jan 11, 2024
@uncenter uncenter requested a review from sxyazi January 11, 2024 14:14
@sxyazi
Copy link
Member

sxyazi commented Jan 11, 2024

I feel it would be strange if the code appears at the beginning of the line. On the other hand, people are aware that Windows/Unix (or at least one of them) are different systems, so there is no need to add "on xxx", this forces us to place it at the end of the path.

@uncenter
Copy link
Member Author

I feel it would be strange if the code appears at the beginning of the line.

I think it is more readable if the code appears at the beginning of the line because it reads like a proper sentence. Try reading what I have now and what you are suggesting out loud.

On the other hand, people are aware that Windows/Unix (or at least one of them) are different systems, so there is no need to add "on xxx", this forces us to place it at the end of the path.

I'm not sure what you are mean. The difference between Windows/Unix has nothing to do with us saying "on", adding "on" is purely a grammatical thing in that it doesn't sound correct without it.

docs/faq.md Outdated Show resolved Hide resolved
@uncenter
Copy link
Member Author

uncenter commented Jan 11, 2024

Alright I got a third opinion. Thoughts?

Screenshot 2024-01-11 at 09 41 37 (Discord)

@sxyazi
Copy link
Member

sxyazi commented Jan 11, 2024

NO! I love "either"! Let's choose the first one but keep it here!

@uncenter
Copy link
Member Author

Alright ahah.

@uncenter
Copy link
Member Author

LGTM!

docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/quick-start.md Outdated Show resolved Hide resolved
@uncenter uncenter requested a review from sxyazi January 11, 2024 15:43
@sxyazi
Copy link
Member

sxyazi commented Jan 11, 2024

Everything is fine now!

@uncenter
Copy link
Member Author

Merge?

@sxyazi sxyazi merged commit fa586cc into main Jan 11, 2024
@sxyazi sxyazi deleted the clarify-and-restructure branch January 11, 2024 19:30
@sxyazi
Copy link
Member

sxyazi commented Jan 11, 2024

Merged!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants