Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve configuration section #21

Merged
merged 5 commits into from
Jan 6, 2024
Merged

feat: improve configuration section #21

merged 5 commits into from
Jan 6, 2024

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Dec 6, 2023 •
edited
Loading

Clarifies how to setup a custom configuration of Yazi and adds a note about the YAZI_CONFIG_HOME environment variable. This PR also renames the titles of the subpages in the configuration section to match the path of the config file they represent.

@uncenter
Copy link
Member Author

uncenter commented Dec 7, 2023

I have in interesting idea - yazi config init or something similar to initialize a new configuration in the proper directory, prepopulated with the default/preset configuration.

@sxyazi
Copy link
Member

sxyazi commented Dec 7, 2023

adds a note about the YAZI_CONFIG_HOME environment variable

Nice catch! I forgot to add YAZI_CONFIG_HOME to the docs :)

@uncenter
Copy link
Member Author

uncenter commented Dec 7, 2023

adds a note about the YAZI_CONFIG_HOME environment variable

Nice catch! I forgot to add YAZI_CONFIG_HOME to the docs :)

Yeah I was helping someone in the Discord and they pointed it out in the source code! I think this is a good way to mention it.

@uncenter uncenter mentioned this pull request Dec 16, 2023
Closed
@uncenter
Copy link
Member Author

Should we revisit this?

@sxyazi sxyazi force-pushed the feat/clarify-configuration branch from af8e34f to a11f206 Compare January 6, 2024 00:37
uncenter
uncenter commented Jan 6, 2024
View reviewed changes
Copy link
Member Author

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sxyazi sxyazi merged commit 51336cb into main Jan 6, 2024
@sxyazi sxyazi deleted the feat/clarify-configuration branch January 6, 2024 01:09
@sxyazi
Copy link
Member

sxyazi commented Jan 6, 2024

Merged!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxyazi sxyazi sxyazi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uncenter @sxyazi