-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot enable full border #10
Comments
Thank you that worked! Also thanks for pointing that out that I was re-defining manager. Re-defining manager at the top of the file causes the border not to render.
Perhaps attaching the complete code snippet in a collapsable section in the docs would help users quickstart this? |
Using the patch approach is intended to keep the document up to date with the preset plugin. Even if the preset is updated, users can modify it based on the content of the patch (which lines have been added or removed). Another benefit is that users can have a clearer view of the added code and understand the underlying principles. Having a complete code indeed makes it convenient for users. Maybe we can add a "Patch" button below, and when the user clicks it, it can call the GitHub API to fetch the latest preset and automatically apply these patches using https://github.com/google/diff-match-patch? |
The issue has been resolved; now, full-border is a plugin, so users don't need to manually patch it anymore, https://yazi-rs.github.io/docs/tips/#full-border |
I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I have followed the instructions in: https://yazi-rs.github.io/usage/tips#full-border, but I cannot produce the full border.
Here are the files I created (note, I do have a theme enabled as well):
These are the contents of those files:
I'm not sure why its failing?
The text was updated successfully, but these errors were encountered: