Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable full border #10

Closed
zarifpour opened this issue Oct 26, 2023 · 5 comments
Closed

Cannot enable full border #10

zarifpour opened this issue Oct 26, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@zarifpour
Copy link
Contributor

I have followed the instructions in: https://yazi-rs.github.io/usage/tips#full-border, but I cannot produce the full border.

Here are the files I created (note, I do have a theme enabled as well):

CleanShot 2023-10-26 at 09 21 49 on Arc — New Issue · yazi-rsyazi-rs github io@2x

These are the contents of those files:

CleanShot 2023-10-26 at 09 24 18 on Visual Studio Code — ~ configyazi — theme toml — yazi-rs github io@2x

I'm not sure why its failing?

@sxyazi
Copy link
Member

sxyazi commented Oct 26, 2023

Seems like you missed the bar function:

image

And do not re-define Manager = {}, unless you want to rewrite the entire layout of Yazi.

@zarifpour
Copy link
Contributor Author

Thank you that worked! Also thanks for pointing that out that I was re-defining manager. Re-defining manager at the top of the file causes the border not to render.

Manager = {}

...

Perhaps attaching the complete code snippet in a collapsable section in the docs would help users quickstart this?

@sxyazi
Copy link
Member

sxyazi commented Oct 26, 2023

Using the patch approach is intended to keep the document up to date with the preset plugin. Even if the preset is updated, users can modify it based on the content of the patch (which lines have been added or removed). Another benefit is that users can have a clearer view of the added code and understand the underlying principles.

Having a complete code indeed makes it convenient for users. Maybe we can add a "Patch" button below, and when the user clicks it, it can call the GitHub API to fetch the latest preset and automatically apply these patches using https://github.com/google/diff-match-patch?

@sxyazi sxyazi added the documentation Improvements or additions to documentation label Oct 26, 2023
@sxyazi
Copy link
Member

sxyazi commented Aug 6, 2024

The issue has been resolved; now, full-border is a plugin, so users don't need to manually patch it anymore, https://yazi-rs.github.io/docs/tips/#full-border

@sxyazi sxyazi closed this as completed Aug 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants