Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Priority Mode, Priority Factor, and QoS per-Profile #5

Open
d4mation opened this issue Jun 9, 2021 · 2 comments
Open

Set Priority Mode, Priority Factor, and QoS per-Profile #5

d4mation opened this issue Jun 9, 2021 · 2 comments

Comments

@d4mation
Copy link

d4mation commented Jun 9, 2021

Would this be possible? Looking at the code it seems this will only get read from the 3DS section of the config file.

This could be a useful feature to do things like disabling the top/bottom screen (Assuming this is like Snickerstream in that regard), creating a high performance profile and a high quality profile to switch between, etc.

https://github.com/RattletraPM/Snickerstream/wiki/Settings-101#standard-settings

if (!ini.sections["3ds"]["priority"].empty()) {
this->networkconfig.priority = std::stoi(ini.sections["3ds"]["priority"]);
}
if (!ini.sections["3ds"]["priorityFactor"].empty()) {
this->networkconfig.priorityFactor = std::stoi(ini.sections["3ds"]["priorityFactor"]);
}
if (!ini.sections["3ds"]["jpegQuality"].empty()) {
this->networkconfig.jpegQuality = std::stoi(ini.sections["3ds"]["jpegQuality"]);
}
if (!ini.sections["3ds"]["QoS"].empty()) {
this->networkconfig.QoS = std::stoi(ini.sections["3ds"]["QoS"]);
}

@ashquarky
Copy link
Member

In theory this could be easily rigged up on the ntrview side (even adding it to the menu) - the problem is that, as far as I can tell, NTR CFW on the 3ds side will only accept those parameters on the first connection it receives, and doesn't allow changing them after that point. So in order to change them, you'd have to entirely reboot the 3ds and boot NTR CFW again..

I guess this could be avoided by having ntrview delay connecting until the user presses some button, and allow changing the performance profile in that time? Then those options could be locked out once a connection is made to avoid confusion. Still not my favorite idea, I kinda like how you can boot ntrview and it hooks straight up. Open to ideas here.

(inb4 HzMod)

@d4mation
Copy link
Author

the problem is that, as far as I can tell, NTR CFW on the 3ds side will only accept those parameters on the first connection it receives, and doesn't allow changing them after that point.

That would explain some of the behavior that I was seeing. I'd adjust the ntrview settings via a text editor on my Wii U and when I reconnected I wasn't able to discern a difference.

Maybe the best solution here would be, when parsing the config file, if no profiles are detected as having customized priority mode/priority factor/qos settings then it can auto-connect but otherwise force choosing a profile first? That way users who want that more granular control can have it and those that just want it to start up quickly can have it too.

I can see the granular control being a big deal in scenarios where you want to only stream a single screen for specific games especially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants