-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API calls via backend #6
Comments
can we discuss this on this love to work on this issue |
Good to have you here @Akshaygore1 - I would like to discuss this improvement project with you. I have couple of initial questions before starting, that will be helpful for leading the discussion.
Thanks very much! |
@yashsehgal Can I work on this issue |
Hey @yashsehgal implemented the class like implementations for the apis
working fine for now |
Hi @Akshaygore1 - Great efforts, thanks for spending time on this one. This class-based implementation looks promising and I think we can start adding these updates and you can create a PR for the same. Also, before you create the PR, we can discuss how we are going expose and utilise these methods. For eg., I was thinking of exposing the class itself with name Also, would you like to work on it's documentation as well. In #2 there's work going on related to docs Migration, we can discuss about the docs part there, if you're willing to take up that part. Thanks you so much! Excited for the PR 🎉 |
Hey @yashsehgal ,
|
Planning to work on a backend supported set of methods similar to all the ones we have inside
useGitHub()
hook. Keeping a hook for all the methods will be a handy thing in frontend, but for server-side modules and SSR, it will not work in such cases.As a solution, we should have a class-based implementation supported as well. Which can have a DX something like,
These methods will perform the same actions as the functions inside
useGitHub()
. Also, these methods will be shared across both hooks and classes, considering the better coding patterns.The text was updated successfully, but these errors were encountered: