-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Q/A Session Interface #25
base: master
Are you sure you want to change the base?
Conversation
shristigupta12
commented
Oct 17, 2023
- resolves [Task]: Q/A Session Interface #17
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I have made a rough functionality code all in the page.tsx file and the updation of answer is not working as of now. |
npm run build command is not showing any errors in my vs code but vercel deployment is still facing issues. Will solve this problem tomorrow |
@yashsehgal please give your reviews on everything I did till now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the following changes and make sure you try building before pushing changes. Use npm run build
mocks/qna-questions-mock.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do add random questions of different word lengths for better UI clarity. You can use ChatGPT to generate questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
{data.map((q, index) => { | ||
return ( | ||
<QnaQuesCard | ||
key={index} | ||
question={q.question} | ||
score = {q.score} | ||
questionId={q.questionId} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use better naming conventions. Instead of q
use question
types/qna-que-card.d.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type is related to Q/A session, thus this type doesn't need a new file,
instead add this type to the qna-session.d.ts
file
Also, the background of box card is breaking and showing dark bg color. Make sure to find it's causing styles and fix this as well. cc @shristigupta12 |
Yeah, I also tried that. The issue was occurring during runtime. Note: Always, make sure the write a check for empty states. |
Noted |
I have imported the TipTap but I have not styled it yet. Hence I have commented it's component and have shown the old text-area for now |
@yashsehgal please give review on the code till now |