Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Q/A Session Interface #25

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

✨ Q/A Session Interface #25

wants to merge 21 commits into from

Conversation

shristigupta12
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prepmeup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 6:21am

@shristigupta12
Copy link
Collaborator Author

I have made a rough functionality code all in the page.tsx file and the updation of answer is not working as of now.

@shristigupta12
Copy link
Collaborator Author

npm run build command is not showing any errors in my vs code but vercel deployment is still facing issues. Will solve this problem tomorrow

@shristigupta12
Copy link
Collaborator Author

@yashsehgal please give your reviews on everything I did till now

Copy link
Owner

@yashsehgal yashsehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes and make sure you try building before pushing changes. Use npm run build

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do add random questions of different word lengths for better UI clarity. You can use ChatGPT to generate questions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 9 to 16
{data.map((q, index) => {
return (
<QnaQuesCard
key={index}
question={q.question}
score = {q.score}
questionId={q.questionId}
/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use better naming conventions. Instead of q use question

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is related to Q/A session, thus this type doesn't need a new file,
instead add this type to the qna-session.d.ts file

@yashsehgal
Copy link
Owner

Also, the background of box card is breaking and showing dark bg color. Make sure to find it's causing styles and fix this as well. cc @shristigupta12

image

@yashsehgal
Copy link
Owner

npm run build command is not showing any errors in my vs code but vercel deployment is still facing issues. Will solve this problem tomorrow

Yeah, I also tried that. The issue was occurring during runtime. questions array was empty and being mapped, thus I added questions?.map(... everywhere to resolve this issue.

Note: Always, make sure the write a check for empty states.

@shristigupta12
Copy link
Collaborator Author

Please make the following changes and make sure you try building before pushing changes. Use npm run build

Noted

@shristigupta12
Copy link
Collaborator Author

I have imported the TipTap but I have not styled it yet. Hence I have commented it's component and have shown the old text-area for now

@shristigupta12
Copy link
Collaborator Author

@yashsehgal please give review on the code till now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Q/A Session Interface
2 participants