Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new model retail sales forecasting #112

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gos24abhik
Copy link

Description

This PR introduces a new machine learning model for retail sales forecasting, designed to predict future sales based on historical data. The model utilizes various features, including date, weekly sales, and holiday indicators, to provide accurate sales predictions.

Issue Resolved

This PR resolves #102 by adding new model retail sales forecaster.

Changes Made

  • Added a new model for retail sales forecasting located in the models/retail_sales_forecasting directory.
  • Implemented model.py and predict.py to handle model training and predictions.
  • Integrated the model into the Streamlit app by adding a new section in app.py to allow users to access the retail sales forecasting feature.

Screenshots or Videos

![Retail Sales Forecaster]
Screenshot 2024-10-10 125833

Additional Details

  • The model uses the following features for prediction:
    • date: The date of the sales transaction.
    • weekly_sales: The total sales amount for the week.
    • is_holiday: A binary indicator specifying whether the week includes a holiday (1 for holiday, 0 for non-holiday).
  • The model aims to help businesses optimize inventory management and enhance decision-making based on predicted demand.

Checklist

  • My code follows the current project structure
  • I have thoroughly reviewed and updated the requirements.txt file to include any new packages
  • The predict.py file includes a properly implemented model_details() function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.
  • I have added relevant tests (if necessary).
  • I have added comments in the code where needed.
  • This PR is submitted under Hacktoberfest.
  • This PR is submitted under GirlScript Summer of Code (GSSoC-Extd).

Copy link
Owner

@yashasvini121 yashasvini121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with these changes, your model isn't working either,
I am getting these errors, let me know if you have any other queries.

Fix it:
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong json format, compare your json structure with other files

Comment on lines +7 to +8
model_path = os.path.join("models", "model.pkl")
scaler_path = os.path.join("models", "scaler.pkl")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong file paths, its in your_model/saved_models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model] Retail Sales Forecasting
2 participants