Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in internal edge cuts, panelize rounds edges #695

Closed
3 tasks done
idank opened this issue May 23, 2024 · 4 comments
Closed
3 tasks done

Regression in internal edge cuts, panelize rounds edges #695

idank opened this issue May 23, 2024 · 4 comments

Comments

@idank
Copy link

idank commented May 23, 2024

Prerequisites

  • I have read FAQ
  • I have searched existing issues (including closed ones)
  • I use KiKit at least version 1.5.1 (older version are not supported)

KiKit version

kikit, version 1.5.1

KiCAD version

8.0.2

Operating system

Ubuntu

Description

panelize seems to go from this:

image

to this:

image

It used to work OK a couple of months ago when I opened #663.

Steps to Reproduce

https://gist.github.com/idank/e0e9a3a2352c16619a921e15b458fc7a

@yaqwsx
Copy link
Owner

yaqwsx commented May 23, 2024

You haven't provided the panelization settings. If KiKit processes the file as is, there is no change in the contour outline. I expect you to use millradius, but I don't know with what radius. Without this information, there is not much I can do.

If you use millradius: 0.5mm then the regression is already fixed in upstream.

@idank
Copy link
Author

idank commented May 23, 2024

Ah sorry, I seem to be using:

"post": {
        "millradius": "1mm"
    }

Was there a recent change so this started to apply to internal edges too? I haven't changed my kikit settings, but there were some kicad minor upgrades since I lasted tested it on this kind of footprint.

@yaqwsx
Copy link
Owner

yaqwsx commented May 23, 2024

The dogbones in your file are formed by arcs with a radius of 0.5mm. They cannot be milled with an end mill with a radius of 1mm - the mill doesn't fit. Therefore, KiKit's current behavior is correct. If it used to behave differently, it was a bug.

@idank
Copy link
Author

idank commented May 23, 2024

Makes sense, thanks!

@idank idank closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants