Replies: 1 comment
-
Having this implemented would be definitely welcomed. There were, however, tasks on KiKit that had much higher priority for me so I rather implemented them. Therefore, if you submit a PR I will be happy to merge it. Once we have this, I don't see a point in having this behavior enabled by a switch - I cannot think of a use case when you would like to rotate the designs but keep the labels upright. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is a known issue covered in FAQ: https://github.com/yaqwsx/KiKit/blob/master/doc/faq.md#i-rotated-my-board-in-a-panel-and-the-component-references-did-not-rotate
The proposed solution (uncheck "keep upright" on all reference labels) surely works, but it takes quite some time to do that, and disabling that option also complicates editing original PCB layouts, before they're panelized.
Expected behavior
How can that be achieved?
I've quickly tested a simple approach: within
appendBoard()
, if a text label of a component (reference or value) has "keep upright" attribute set, we calculate actual orientation of the label before component has been rotated, remove "keep upright" attribute, and rotate the label so that it keeps its original orientation. Afterwards, when the component is rotated, labels will be rotated by the same amount.I'd like to hear your opinion on this @yaqwsx. I can implement the necessary code change for 5.1 branch, and this behavior can be made optional (e.g. enabled only when a certain optional argument of
appendBoard()
is set toTrue
).Beta Was this translation helpful? Give feedback.
All reactions