Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Premium] v5.19.0's 1.21.3 support might have broken support for previous versions #981

Closed
Mitality opened this issue Nov 24, 2024 · 7 comments
Labels
Status: Resolved The issue/problem has been resolved. Type: Bug Identifies a bug or a problem.

Comments

@Mitality
Copy link

Mitality commented Nov 24, 2024

Describe the bug
I have updated a PaperMC 1.21.1 #131 server from GadgetsMenu [Premium] v5.18.9 to v5.19.0.
This resulted in the plugin no longer enabling:

[17:08:15 ERROR]: Error occurred while enabling GadgetsMenu v5.19.0 (Is it up to date?)
java.lang.IncompatibleClassChangeError: Method 'org.bukkit.Sound org.bukkit.Sound.valueOf(java.lang.String)' must be Methodref constant
        at GadgetsMenu.jar/com.yapzhenyie.GadgetsMenu.utils.SoundEffect.<clinit>(SoundEffect.java:1547) ~[GadgetsMenu.jar:?]
        at GadgetsMenu.jar/com.yapzhenyie.GadgetsMenu.cosmetics.pets.types.EntityAllay.<init>(EntityAllay.java:13) ~[GadgetsMenu.jar:?]
        at GadgetsMenu.jar/com.yapzhenyie.GadgetsMenu.cosmetics.pets.TypeManager.initializePets(TypeManager.java:19) ~[GadgetsMenu.jar:?]
        at GadgetsMenu.jar/com.yapzhenyie.GadgetsMenu.GadgetsMenu.onEnable(GadgetsMenu.java:316) ~[GadgetsMenu.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:641) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:590) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:753) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:515) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:329) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1214) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:329) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]

API Docs (1.21.1): https://helpch.at/docs/1.21.1/org/bukkit/Sound.html#valueOf(java.lang.String)
API Docs (1.21.3): https://helpch.at/docs/1.21.1/org/bukkit/Sound.html#valueOf(java.lang.String)

To Reproduce
Steps to reproduce the behavior:
- explained above

Expected behavior
The plugin should successfully enable on all supported Minecraft versions, not just 1.21.3

Further Information (please complete the following information):

  • Server Version: PaperMC 1.21.1 #131
  • GadgetsMenu Version: v5.19.0

Screenshots
image

Additional Information
Don't think anything else is necessary here, if you need more information, feel free to ask

@yapzhenyie yapzhenyie added Type: Bug Identifies a bug or a problem. Status: In Progress The issue/feature is working in progress which will be fixed/implemented in the next update. labels Nov 25, 2024
@yapzhenyie
Copy link
Owner

/
Thank you for reporting this issue, it will be fixed in the next update.

@yapzhenyie yapzhenyie added Status: Resolved The issue/problem has been resolved. and removed Status: In Progress The issue/feature is working in progress which will be fixed/implemented in the next update. labels Nov 26, 2024
@yapzhenyie
Copy link
Owner

This issue has been fixed. Please check for the new update.

@GG-MD
Copy link

GG-MD commented Dec 2, 2024

@yapzhenyie
not fixed

[23:26:46] [Server thread/WARN]: [GadgetsMenu] Task #15057096 for GadgetsMenu v5.19.1 generated an exception
java.lang.IncompatibleClassChangeError: Method 'org.bukkit.Sound org.bukkit.Sound.valueOf(java.lang.String)' must be Methodref constant
	at GadgetsMenu.jar/depend.xxmicloxx.NoteBlockAPI.utils.EnumSound.getSound(EnumSound.java:49) ~[GadgetsMenu.jar:?]
	at GadgetsMenu.jar/depend.xxmicloxx.NoteBlockAPI.utils.InstrumentUtils.getInstrument(InstrumentUtils.java:10) ~[GadgetsMenu.jar:?]
	at GadgetsMenu.jar/depend.xxmicloxx.NoteBlockAPI.songplayer.PositionSongPlayer.playTick(PositionSongPlayer.java:47) ~[GadgetsMenu.jar:?]
	at GadgetsMenu.jar/depend.xxmicloxx.NoteBlockAPI.songplayer.SongPlayer.lambda$start$1(SongPlayer.java:105) ~[GadgetsMenu.jar:?]
	at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:86) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:475) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1770) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:513) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1642) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1342) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:333) ~[purpur-1.21.1.jar:1.21.1-2329-803bf62]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

@Mitality
Copy link
Author

Mitality commented Dec 5, 2024

The issue now no longer occurs on startup, but it still does when trying to use music related gadgets

@yapzhenyie
Copy link
Owner

Thank you for reporting this issue, it will be fixed in the next update.

@yapzhenyie
Copy link
Owner

This issue has been fixed. Please check for the new update.

@Mitality
Copy link
Author

Mitality commented Dec 5, 2024

Yep, works now, tysm! <3

Let me now kindly redirect your attention back to my other, slightly older, issue (head:OWNER_HEAD doesn't work in player inventories) ^^
Steve's head isn't bad, but I'd still prefer my own x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Resolved The issue/problem has been resolved. Type: Bug Identifies a bug or a problem.
Projects
None yet
Development

No branches or pull requests

3 participants