-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctests fail with default features disabled #80
Comments
I use examples for tests, and that is exactly what I run for each test Lines 33 to 49 in 90ff555
If you use nix shell, you can type If you see something is too verbose, or not DRY, I will also be happy to get a refactor. :) |
In that case, will it actually run the docstring tests at all? I'm running "cargo test --no-default-features", which will also run the docstrings. |
No, it didn't. Thanks for pointing out this. One of the dev dependencies is missing, I put it back in #81 |
Hi @jelmer, |
Hi @yanganto , I'd already patched the Debian package but I'll take another look when I do the next upload. Let's close this issue if you believe it's been fixed - I can always reopen it if it doesn't work for me? |
I get 25 failures, most related to docstrings for runtime. Happy to provide a PR, but I'm not sure what the best approach here is.
One option would be to add "#[cfg(feature = "runtime")] {" blocks to each of the docstrings, but that seems a bit repetitive.
The text was updated successfully, but these errors were encountered: