Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Wallet Logic #78

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Black-Wattle
Copy link

Wallet logic update

This pull updates logic around the wallet provider to make it more user friendly. It has the following changes:

  • Adds a LocalStorage hook
  • Uses LocalStorage to remember wallet preference
  • Auto-Wallet initialisation on refresh if a user has consented
  • Moves the Page component into the App.tsx file so only the page content is modified on navigation
  • Adds a selection modal for various wallets
  • Displays wallet address after login, similar pattern used across Web3 apps
  • Displays wallet icons after login
  • Fixes SignOut logic

Before Merge:

  • Choose wallet providers to include & add them to UseWalletProvider
    • Include the relevant icons
    • Setup relevant infra

Preview

Here is a staging link for the proposed changes: https://yam-finance.vercel.app
Note: Wallet Link and Connect will fail to fetch as they are using dummy providers.

Lewi

@Black-Wattle
Copy link
Author

@clintonbembryjr thanks for the feedback. Do you think you'll want to operate a walletConnect relay and setup an RPC provider for wallet provider picker?

If not I'll remove the wallet picker and modal we can merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants