Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code cleanup #35

Open
nash-ye opened this issue Sep 15, 2013 · 0 comments
Open

General code cleanup #35

nash-ye opened this issue Sep 15, 2013 · 0 comments

Comments

@nash-ye
Copy link
Contributor

nash-ye commented Sep 15, 2013

There are some code can be improved.

  • Use implode() instead of join() alias
  • Use echo instead of print
  • Remove the not-need temperately variables.
  • Separate the code to more smaller functions.
  • Remove the not-needed echo callbacks.
  • Rewrite the long-checks to more readable code.
    ...etc
westonruter added a commit that referenced this issue Jul 30, 2014
@westonruter
Squashed 'bin/' changes from cc5a003..2dbb4ca
b83ad90 
2dbb4ca Make readme section front-matter pattern not greedy
5b2b963 Move Travis build badge right after metadata block
e60070a Add support for parsing readme section front-matter
ca371f1 Merge pull request #36 from x-team/develop
2cfb6e9 Add support for WPCS folder re-structure
e55d064 Merge branch 'master' into develop
b782342 Use master branch for coveralls build status
d7722bd Supply default PHPCS_IGNORE
1efac8e Add composer
13db3de Trial support for coveralls
b88ad0b Merge pull request #35 from x-team/develop
2ad10ee Add sample .ci-env.sh to readme
ffbe9ea Add built-in VVV support to pre-commit hook
98f6174 Fix PHPCS issues new from WordPress:core-extra
54f710a Use same WP_VERSION in .travis.yml as WP-CLI's template
d8e6928 Fetch and use latest install-wp-tests.sh from wp-cli GitHub repo
d6c29fc Use .ci-env.sh (nee .travis.before_script.sh) in pre-commit hook
3344571 Fix .travis.yml syntax error
fb5d1cc Allow PHPCS and WPCS to pull from different locations
4529787 Improve URL regex for readme builder
dab2ab1 Merge commit '025f3510009d530e4313d4c94a714e555f467288'
1139f0d Make PHPCS ruleset file naming consistent
e73f2d6 Updating readme parser
02cb910 Post connector tests
ce084cf Append branch param to Travis CI status image URL
91dd266 Changelog for 0.3 release

git-subtree-dir: bin
git-subtree-split: 2dbb4cafdb4e98d97f1ab5f13a4f73addfa9fe54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nash-ye