XDOCKER-8: Also offer an alpine-based image to reduce download size #20

ASHISH932 · 2019-05-26T08:51:32Z

Alpine based XWIKI image

evalica · 2019-05-27T15:53:55Z

Hi. The commit message should have contained also the issue title,
XDOCKER-8: Also offer an alpine-based image to reduce download size

see https://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HRule:AlwaysputaJIRAissuereferenceincommitmessages

-> mysql implementation

xwikiorgci · 2019-05-28T09:24:04Z

11/mysql-alpine-tomcat/Dockerfile

+#    _/ /'`\ \_     \  /\  /    | |  | |`\ \  | |
+#   |____||____|     \/  \/    [___][__|  \_][___]
+
+MAINTAINER Vincent Massol <[email protected]>


This should be changed as I'm not planning to be the maintainer for it ;) @ASHISH932 Since you're contributing this are you ok to also maintain it on the long run? Thx

xwikiorgci · 2019-05-28T09:25:48Z

Thanks @ASHISH932 . There's a problem with this PR: it's not using the template mechanism and this contains a lot of duplicated code, which is really not nice for maintainance. Could you refactor it to use the template and build mechanism with Gradle as it's done for the other images? Thx!

xwikiorgci · 2019-05-28T09:26:30Z

FTR it would also allow me to review more easily this PR to see what are the differences with the other image files, without the duplication :)

ASHISH932 · 2019-05-28T22:42:21Z

Thanks, I would be doing the changes, could you help me by reviewing my next 6-7 issues, so that I could understand the complete process and code base properly, then I could maintain this image.

ASHISH932 · 2019-05-28T22:42:56Z

FTR
I started with the clone of mysql-tomcat container code. There I edited certain things in *Dockerfile only *.
Changes done:-

image -> tomcat:8-jre8-alpine (line 20)
Changed the command that downloads different library as alpine does not contain apt-get (line 35-40)
Used mysql-connector-java as a connector to mysql(line 42 & 61)

If you want I could restart with the template?

vmassol · 2019-05-29T08:13:52Z

If you want I could restart with the template?

Just checked your PR and it's still not correct since it's still not using the template mechanism :)

* Modified template file to genrate alpine image * Modified Dockerfile to support alpine os * gradlew generated new files with new naming convention * name of container folder now is db-servelet-image (earlier db-servelet) e.g. mysql-tomcat-alpine

ASHISH932 · 2019-06-21T14:16:12Z

Added alpine to the template. But for that naming convention of folders are changed.
It has been changed to mysql-tomcat-alpine or mysql-tomcat-debian

FTR
changed template/Dockerfile
changed build.gradle file

ASHISH932 · 2019-06-21T14:28:49Z

I think we should remove mysql-tomcat and postgres-tomcat directory as we have a replacement now mysql-tomcat-debian and postgres-tomcat-debian. I have not removed it in this commit. If we remove the files then we also need to update it in official-image repo

vmassol · 2019-08-20T09:19:25Z

template/Dockerfile

-FROM tomcat:8-jdk8-slim
+
+<% if (image == 'debian') print 'FROM tomcat:8-jdk8-slim'
+   else if (image == 'alpine') print 'FROM tomcat:8-jre8-alpine' %>


I'm wondering if using a jre instead of a jdk wouldn't cause trouble.

I have tested the app was working fine, but if you have other concerns I would try to change it?

Well, we were using a JDK and you changed it to a JRE so there got to be a reason :) It's weird to use a JDK for "debian" and a JRE for "alpine". It raises questions as to why we're doing this....

Basically we were using jar and war files. So I thought there is no need for JDK as we don't want to compile anything. That's why I choose JRE.

JRE should be sufficient to run Java apps. The package and image layer will be smaller too.

JRE should be fine, yes.

All variants should use a jre to run the software. You might only need the jdk to build the jar/war.

If only a JRE is needed (still not sure it's the case and there might be some 3rd party lib we use that would require a JDK. As an example, back in the days - don't know if it's still the case or not -, if you use JSPs you needed a JDK since it had to compile the JSP to java code), then indeed we should change all images. We also need to update https://dev.xwiki.org/xwiki/bin/view/Community/SupportStrategy/JavaSupportStrategy/ to explain that only a JRE is needed for running XWiki.

The XWiki Debian package depends on openjdk-11-jre-headless so yes, the JRE is definitely enough, and it's like this since we have Debian packages.

ok good.

https://www.xwiki.org/xwiki/bin/view/Documentation/AdminGuide/Installation/#HHardwareandSoftwarerequirements updated

https://jira.xwiki.org/browse/XDOCKER-233 implemented

vmassol · 2019-08-20T09:20:55Z

template/Dockerfile

+    unzip \
+    procps
+
+RUN curl -L -o /mysql-connector-java-5.1.34.jar https://repo1.maven.org/maven2/mysql/mysql-connector-java/5.1.34/mysql-connector-java-5.1.34.jar


This is potentially a problem because it requires quite some maintenance. Isn't there a way to use the "latest" version?

What about postgresql?

I searched for the way to add "latest " version or to add through apk but I was unable to find the solution. I just found a bit better way that is to maintain the version through arguments.

https://github.com/LasLabs/docker-alpine-jira/blob/master/Dockerfile

It only contains MySQL for now. The changed naming convention of variants in build.gradle supports it.

I searched for the way to add "latest " version or to add through apk but I was unable to find the solution. I just found a bit better way that is to maintain the version through arguments.

Did you commit anything about this? What's your plan?

I think we should maintain it with version. Should I commit that?

vmassol · 2019-08-20T09:21:15Z

template/Dockerfile

@@ -52,15 +66,17 @@ RUN rm -rf /usr/local/tomcat/webapps/* && \\
  mkdir -p /usr/local/tomcat/temp && \\
  mkdir -p /usr/local/xwiki/data && \\
  curl -fSL "\${XWIKI_URL_PREFIX}/xwiki-platform-distribution-war-\${XWIKI_VERSION}.war" -o xwiki.war && \\
-  echo "\$XWIKI_DOWNLOAD_SHA256 xwiki.war" | sha256sum -c - && \\
+  echo "\$XWIKI_DOWNLOAD_SHA256  xwiki.war" | sha256sum -c - && \\


why the extra space? typo? :)

In alpine, the extra space is required for the sha256 to work. Without space it was failing

@ASHISH932 I think we're not talking about the same thinf. This is just the echo command. I don't see why it would require 2 spaces, it doesn't make sense to me :)

I know that felt weird to me also, but that's how it works. See this issue.
gliderlabs/docker-alpine#174

vmassol · 2019-08-20T09:22:03Z

template/Dockerfile

+    procps \\''' %>
+    <% if (db == 'mysql' && image == 'debian') print 'libmysql-java && \\'
+       if (db == 'postgres' && image == 'debian') print 'libpostgresql-jdbc-java && \\' %>
+<% if (image == 'debian') print 'rm -rf /var/lib/apt/lists/*' %>


Is this needed since there's alreayd the IF above about debian?

These IF are not nested. The second IF starts after the first IF end

ASHISH932 changed the title ~~#Issue XDOCKER-8~~ XDOCKER-8: Also offer an alpine-based image to reduce download size May 27, 2019

XDOCKER-8: Also offer an alpine-based image to reduce download size

843afb6

-> mysql implementation

xwikiorgci reviewed May 28, 2019

View reviewed changes

ASHISH932 force-pushed the master branch from 1a288c9 to 843afb6 Compare June 21, 2019 13:56

evalica and others added 4 commits June 21, 2019 19:27

XDOCKER-108: Upgrade stable version to 11.4

5307af7

XDOCKER-109: Switch from tomcat:8-jre8-slim to tomcat:8-jdk8-slim

fd97e12

Merge branch 'master' into master

3dc51c0

vmassol reviewed Aug 20, 2019

View reviewed changes

vmassol self-assigned this Aug 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XDOCKER-8: Also offer an alpine-based image to reduce download size #20

XDOCKER-8: Also offer an alpine-based image to reduce download size #20

ASHISH932 commented May 26, 2019

evalica commented May 27, 2019

xwikiorgci May 28, 2019

xwikiorgci commented May 28, 2019

xwikiorgci commented May 28, 2019

ASHISH932 commented May 28, 2019

ASHISH932 commented May 28, 2019 •

edited

Loading

vmassol commented May 29, 2019

ASHISH932 commented Jun 21, 2019 •

edited

Loading

ASHISH932 commented Jun 21, 2019

vmassol Aug 20, 2019

ASHISH932 Aug 24, 2019

vmassol Sep 10, 2019

ASHISH932 Sep 11, 2019

sebastianrothe May 2, 2022

tmortagne May 2, 2022

sebastianrothe May 2, 2022 •

edited

Loading

vmassol May 4, 2022

tmortagne May 4, 2022

vmassol May 4, 2022

vmassol Aug 20, 2019

vmassol Aug 20, 2019

ASHISH932 Aug 24, 2019

ASHISH932 Aug 24, 2019

vmassol Sep 10, 2019 •

edited

Loading

ASHISH932 Sep 11, 2019

vmassol Aug 20, 2019

ASHISH932 Aug 24, 2019

vmassol Sep 10, 2019

ASHISH932 Sep 11, 2019

vmassol Aug 20, 2019

ASHISH932 Aug 24, 2019

XDOCKER-8: Also offer an alpine-based image to reduce download size #20

Are you sure you want to change the base?

XDOCKER-8: Also offer an alpine-based image to reduce download size #20

Conversation

ASHISH932 commented May 26, 2019

evalica commented May 27, 2019

Choose a reason for hiding this comment

xwikiorgci commented May 28, 2019

xwikiorgci commented May 28, 2019

ASHISH932 commented May 28, 2019

ASHISH932 commented May 28, 2019 • edited Loading

vmassol commented May 29, 2019

ASHISH932 commented Jun 21, 2019 • edited Loading

ASHISH932 commented Jun 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastianrothe May 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vmassol Sep 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ASHISH932 commented May 28, 2019 •

edited

Loading

ASHISH932 commented Jun 21, 2019 •

edited

Loading

sebastianrothe May 2, 2022 •

edited

Loading

vmassol Sep 10, 2019 •

edited

Loading