Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Scroll problems if you starts on text #3613

Open
RayZik opened this issue Jan 24, 2022 · 1 comment · May be fixed by #4979
Open

[iOS] Scroll problems if you starts on text #3613

RayZik opened this issue Jan 24, 2022 · 1 comment · May be fixed by #4979
Labels
help wanted type/bug Something is misbehaving unconfirmed

Comments

@RayZik
Copy link

RayZik commented Jan 24, 2022

Trying to scroll the terminal window can still be a challenge if there’s a lot of data on the screen like when the screen fills with error messages. It seems you need to start your scroll with your finger in an area where there is no text. When the screen is full of text, that’s difficult. Here’s a short video demonstrating the issue. I turned on Assistive touch to demonstrate the problem.

You can see how if I try to start my scroll with my finger on some text, it ignores the scroll. If I start it where there is no text, scroll works fine.

This issue reproduces only on iOS. Android works fine.

https://youtu.be/hzMkbgeYLM0 - reproduce

Details

  • Browser and browser version: Ionic 5.8.1
  • OS version: iOS 15.1
  • xterm.js version: 4.16.0
  • xterm-addon-fit version: 0.5.0

Steps to reproduce

  1. Init new ionic project (https://ionicframework.com/docs/react/your-first-app)
  2. Create a new terminal
  3. Input too much text
  4. Run xcode and start the app
  5. Try to scroll on text

Thanks!
@secret104278
Copy link

I use xterm-addon-canvas as a workaround.

@Tyriar Tyriar added type/bug Something is misbehaving help wanted unconfirmed labels Nov 20, 2022
@isontheline isontheline mentioned this issue May 16, 2023
Closed
4 tasks
xdavidwu added a commit to xdavidwu/xterm.js that referenced this issue Mar 4, 2024
@xdavidwu
DomRenderer: fix touch scrolling starting from text
b6d4435 
When scrolling with touchscreen starting from text, as soon as touch
leaves the text span, the touch event stops, making touch-scrolling able
to scroll one row only.

This fixes it by setting `pointer-events: none` to text spans, excluding
them from hit-testing so that touch events won't be constrained to them.

Fixes xtermjs#3613
@xdavidwu xdavidwu linked a pull request Mar 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/bug Something is misbehaving unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DomRenderer: fix touch scrolling starting from text xdavidwu/xterm.js
3 participants
@Tyriar @secret104278 @RayZik