Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos in comments #130

Merged
merged 1 commit into from
Nov 6, 2024
Merged

typos in comments #130

merged 1 commit into from
Nov 6, 2024

Conversation

MichaelChirico
Copy link
Contributor

Sorry for the trivial PR :)

Full context: actually I first opened the branch as our tool flags "splitted":

pROC/R/roc.R

Line 238 in f03d246

splitted <- split(predictor, response)

I actually don't have any issue with using 'splitted' as a variable name for shorthand. But I only noticed this after already starting the PR so I figured I'd send along as it's better than deleting the corrections I'd already made.

@xrobin xrobin closed this Nov 6, 2024
@xrobin xrobin reopened this Nov 6, 2024
@xrobin xrobin merged commit 181a40d into xrobin:master Nov 6, 2024
0 of 13 checks passed
@xrobin
Copy link
Owner

xrobin commented Nov 6, 2024

Loos good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants