Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab-option-026 #724

Open
ndw opened this issue Sep 29, 2024 · 2 comments
Open

ab-option-026 #724

ndw opened this issue Sep 29, 2024 · 2 comments

Comments

@ndw
Copy link
Contributor

ndw commented Sep 29, 2024

I think that the p:option in this test is missing static="true". Otherwise, I think it needs the eager-eval feature flag. Or I'm confused about how this test is substantially different from ab-option-064 where an error is not raised.

I think the same is true of ab-option-027.

@xml-project
Copy link
Member

xml-project commented Sep 29, 2024

  • 026 needs eager-evaluation: The XPath expression for the option is invalid, but option is never used.
  • 027 Not sure about that: Here the XPath expression for the default value is invalid, but a value is provided on the call. Can we simply ignore the error in the default expression?
  • 064 is marked as "lazy-eval", isnt it?

@ndw
Copy link
Contributor Author

ndw commented Sep 29, 2024

Yes, 064 is marked eager. I was only pointing out that I think 026 is the same situation as 064. Sounds like you agree.

For 027, if you're doing lazy evaluation, I certainly can't think of any reason why you'd attempt to evaluate the default if a value has been provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants