Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In/Out of combat improvement #368

Open
xpdota opened this issue Apr 5, 2023 · 0 comments
Open

In/Out of combat improvement #368

xpdota opened this issue Apr 5, 2023 · 0 comments

Comments

@xpdota
Copy link
Owner

xpdota commented Apr 5, 2023

Currently, OP's InCombat inGameCombat is the only thing considered for being in or out of combat. This should be amended to work like this to reduce race conditions:

  • If both OP and ACT say we're out of combat, and we were in combat before, combat has ended
  • When OP or ACT changes from out-of-combat to in-combat, consider that a start of combat
  • When OP changes from in-combat to out-of-combat, consider that an end of combat (but do not consider ACT, since that could have all sorts of funkiness with user settings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant