Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read ACT Log Folder from Config #264

Open
Lusaca87 opened this issue Jan 27, 2023 · 3 comments
Open

Read ACT Log Folder from Config #264

Lusaca87 opened this issue Jan 27, 2023 · 3 comments

Comments

@Lusaca87
Copy link

Hello!

After playing around with triggevent, i found an issue!

under "advanced" in the section directories there ist a button with "open act log dir" but this is used for the default one.
if a user (like me) change the directory in the settings you can read the correct folder from "%appdata%\Advanced Combat Tracker\Config\Advanced Combat Tracker.config.xml"

in this xml file exists a node Config\SettingsSerializer ->

maybe this helps to open find a way to open the correct folder :)

@xpdota
Copy link
Owner

xpdota commented Jan 29, 2023

Would it help if I just allowed that to be a setting you can customize? The log folder isn't really used for anything other than that button and to make the file picker default to the logs folder when you're importing a log.

@Lusaca87
Copy link
Author

Hello.

I'm not sure if it would help, plus it would be a potential risk if you allow a user to enter something, especially if it's system relevant information.... (My experience after a few years of developing some applications).

I've also been looking in the repository for where the button is to create a code snippet but haven't found it yet.

@Lusaca87
Copy link
Author

Lusaca87 commented Jan 29, 2023

i was a little bit bored, maybe this is usefull for you:
change the subfix from txt to java to test it.

The sourcecode is generated for java 1.8 but it should be also work with newer versions.

Main.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants