Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Impl collective communication interface #46

Merged
merged 14 commits into from
Aug 2, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Jul 13, 2023

Related #22

Tested on xorbits.

In the case of worker number 5 for tpch 100, broadcast is much more slower than copy_to.
Maybe when cluster scale is very large, collective communication may speed up. But I do not know now.
See issue: https://stackoverflow.com/questions/26558189/mpi-broadcast-very-slow

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.0.9 milestone Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #46 (cac0e28) into main (c3ac228) will increase coverage by 0.34%.
The diff coverage is 95.51%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   93.66%   94.00%   +0.34%     
==========================================
  Files          42       47       +5     
  Lines        3361     3671     +310     
  Branches      672      708      +36     
==========================================
+ Hits         3148     3451     +303     
- Misses        141      145       +4     
- Partials       72       75       +3     
Flag Coverage Δ
unittests 93.87% <95.51%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/collective/utils.py 63.63% <63.63%> (ø)
python/xoscar/collective/core.py 95.57% <95.57%> (ø)
python/xoscar/collective/process_group.py 96.71% <96.71%> (ø)
python/xoscar/backends/communication/ucx.py 94.61% <100.00%> (+2.27%) ⬆️
python/xoscar/collective/__init__.py 100.00% <100.00%> (ø)
python/xoscar/collective/common.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ChengjieLi28 ChengjieLi28 force-pushed the feat/collective_interface branch 2 times, most recently from c6dc28f to ba054be Compare July 26, 2023 08:17
python/xoscar/collective/core.py Show resolved Hide resolved
python/xoscar/collective/common.py Outdated Show resolved Hide resolved
python/xoscar/collective/common.py Outdated Show resolved Hide resolved
python/xoscar/collective/core.py Outdated Show resolved Hide resolved
python/xoscar/collective/core.py Show resolved Hide resolved
python/xoscar/collective/core.py Show resolved Hide resolved
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7943b78 into xorbitsai:main Aug 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants