BUG: The bytes returned by cuda StreamReader may leads to deserialization failed #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When I adapt
copy_to
toxorbits
, xoscar cannot deserialize the transferred cupy object.In xorbits, all the cuda object will use
rmm.DeviceBuffer
-based object to store actual data.But in xoscar, the result of deserialization could be the organic
bytes
object.I think using
rmm.DeviceBuffer
is definitely correct.Check code requirements