Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The bytes returned by cuda StreamReader may leads to deserialization failed #40

Merged

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

When I adapt copy_to to xorbits, xoscar cannot deserialize the transferred cupy object.
In xorbits, all the cuda object will use rmm.DeviceBuffer-based object to store actual data.
But in xoscar, the result of deserialization could be the organic bytes object.
I think using rmm.DeviceBuffer is definitely correct.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added bug Something isn't working gpu labels Jul 6, 2023
@XprobeBot XprobeBot added this to the v0.0.6 milestone Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #40 (a23008e) into main (7531e22) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   93.79%   93.64%   -0.15%     
==========================================
  Files          43       43              
  Lines        3399     3399              
  Branches      675      675              
==========================================
- Hits         3188     3183       -5     
- Misses        139      145       +6     
+ Partials       72       71       -1     
Flag Coverage Δ
unittests 93.49% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/communication/utils.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit aea295f into xorbitsai:main Jul 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants