Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix socket channel config bug #100

Merged
merged 9 commits into from
Aug 13, 2024
Merged

ENH: Fix socket channel config bug #100

merged 9 commits into from
Aug 13, 2024

Conversation

luweizheng
Copy link
Contributor

In the last PR, we added a parse_config method in socket channel. This method is mainly for extracting listen_elastic_ip in extra_conf.
However, when xorbits calls it, this config contains keyword arguments like ucx in extra_conf.
The config will further affect the following code as asyncio.start_server does not have the ucx keyword argument.

aio_server = await asyncio.start_server(
            handle_connection, host=_host, port=port, **config
        )

In xorbits, this config contains stuff about ucx like: {'ucx': {'tcp': None, 'nvlink': None, 'infiniband': None, 'rdmacm': None, 'cuda-copy': None, 'create-cuda-contex': None}}. This config is from python/xorbits/_mars/deploy/oscar/base_config.yml.

However, SocketChannel does not use the ucx config. So we do not need it here.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added enhancement New feature or request gpu labels Aug 13, 2024
@XprobeBot XprobeBot added this to the v0.3.3 milestone Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (d6465c9) to head (a93e1e5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   88.97%   85.09%   -3.89%     
==========================================
  Files          48       54       +6     
  Lines        4038     4556     +518     
  Branches      770      833      +63     
==========================================
+ Hits         3593     3877     +284     
- Misses        358      586     +228     
- Partials       87       93       +6     
Flag Coverage Δ
unittests 84.92% <ø> (-3.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 3c5a6a3 into xorbitsai:main Aug 13, 2024
12 of 13 checks passed
luweizheng added a commit to luweizheng/xoscar that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants