ENH: Fix socket channel config bug #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, we added a
parse_config
method in socket channel. This method is mainly for extractinglisten_elastic_ip
inextra_conf
.However, when xorbits calls it, this
config
contains keyword arguments likeucx
inextra_conf
.The config will further affect the following code as
asyncio.start_server
does not have theucx
keyword argument.In xorbits, this config contains stuff about ucx like:
{'ucx': {'tcp': None, 'nvlink': None, 'infiniband': None, 'rdmacm': None, 'cuda-copy': None, 'create-cuda-contex': None}}
. This config is frompython/xorbits/_mars/deploy/oscar/base_config.yml
.However, SocketChannel does not use the ucx config. So we do not need it here.
Check code requirements