Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: fix cudf comp issue #803

Merged
merged 2 commits into from
Aug 22, 2024
Merged

ENH: fix cudf comp issue #803

merged 2 commits into from
Aug 22, 2024

Conversation

luweizheng
Copy link
Collaborator

fix cudf comp issue:

  • buffer: buffer._owner, size, _offset
  • cudf and pandas work differently on merge

@XprobeBot XprobeBot added enhancement New feature or request gpu labels Aug 22, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 22, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (3be13c7) to head (beadf54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   80.70%   80.97%   +0.27%     
==========================================
  Files        1070     1070              
  Lines       80015    80015              
  Branches    16522    16522              
==========================================
+ Hits        64574    64792     +218     
+ Misses      13881    13647     -234     
- Partials     1560     1576      +16     
Flag Coverage Δ
unittests 80.92% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinxuye qinxuye merged commit c061016 into xorbitsai:main Aug 22, 2024
30 of 34 checks passed
@luweizheng luweizheng deleted the cudf_issue branch August 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants