Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Delede code on pd < 1.2.2 #797

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

hucorz
Copy link
Collaborator

@hucorz hucorz commented Aug 18, 2024

What do these changes do?

Delede code pd version < 1.2.2

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (2991976) to head (3f438f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   80.70%   80.71%           
=======================================
  Files        1070     1070           
  Lines       80019    80004   -15     
  Branches    16525    16521    -4     
=======================================
- Hits        64583    64574    -9     
+ Misses      13876    13866   -10     
- Partials     1560     1564    +4     
Flag Coverage Δ
unittests 80.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title Delede code pd version < 1.2.2 REF: Delede code on pd < 1.2.2 Aug 19, 2024
@luweizheng luweizheng self-requested a review August 20, 2024 01:12
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 310a866 into xorbitsai:main Aug 20, 2024
27 of 36 checks passed
@hucorz hucorz deleted the delede-pd-version-lt-1.2.2 branch August 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants