Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix tests hang in CI #794

Merged
merged 38 commits into from
Aug 17, 2024
Merged

ENH: Fix tests hang in CI #794

merged 38 commits into from
Aug 17, 2024

Conversation

luweizheng
Copy link
Collaborator

@luweizheng luweizheng commented Aug 10, 2024

  • Some tests hang. It seems that some processes may not exit correctly and will keep printing following logs. This is a workaround. I split the test cases that hang and test them separately.
Message: 'Actor caller has created too many clients (%s >= 100), the global router may not be set.'
  • I move xorbits.pandas and xorbits.numpy from xorbits to test them separately.

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 10, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (4032b78) to head (dbba1e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   75.23%   80.71%   +5.47%     
==========================================
  Files        1058     1070      +12     
  Lines       79800    80019     +219     
  Branches    16499    16525      +26     
==========================================
+ Hits        60041    64584    +4543     
+ Misses      18013    13869    -4144     
+ Partials     1746     1566     -180     
Flag Coverage Δ
unittests 80.66% <ø> (+5.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH: Fix tests hang ENH: Fix tests hang in CI Aug 10, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 2f99f8c into xorbitsai:main Aug 17, 2024
29 of 36 checks passed
luweizheng added a commit to luweizheng/xorbits that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants