Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: column pruning causes missing columns on DataFrameIndex op #743

Merged

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Oct 16, 2023
@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #743 (46721f9) into main (07bef18) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   93.57%   93.24%   -0.34%     
==========================================
  Files        1058     1058              
  Lines       79777    79780       +3     
  Branches    16503    16504       +1     
==========================================
- Hits        74651    74389     -262     
- Misses       3449     3656     +207     
- Partials     1677     1735      +58     
Flag Coverage Δ
unittests 93.18% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cal/tileable/column_pruning/column_pruning_rule.py 98.41% <100.00%> (+0.03%) ⬆️

... and 50 files with indirect coverage changes

@aresnow1 aresnow1 merged commit f67ffd4 into xorbitsai:main Oct 20, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants