Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reduction agg with numpy udf #742

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

luweizheng
Copy link
Collaborator

What do these changes do?

Similar issue like #737

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #742 (f496ca1) into main (b1d828f) will decrease coverage by 5.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   93.34%   88.30%   -5.04%     
==========================================
  Files        1026     1026              
  Lines       79589    79589              
  Branches    16497    16497              
==========================================
- Hits        74290    70281    -4009     
- Misses       3616     7479    +3863     
- Partials     1683     1829     +146     
Flag Coverage Δ
unittests 88.20% <100.00%> (-5.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/xorbits/_mars/dataframe/reduction/max.py 100.00% <100.00%> (ø)
python/xorbits/_mars/dataframe/reduction/mean.py 100.00% <100.00%> (ø)
python/xorbits/_mars/dataframe/reduction/min.py 100.00% <100.00%> (ø)

... and 144 files with indirect coverage changes

Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengjieLi28 ChengjieLi28 merged commit c15148d into xorbitsai:main Oct 16, 2023
29 of 31 checks passed
@luweizheng luweizheng deleted the fix_reduction_agg_udf branch October 16, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants