Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix read_csv with index_col #736

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

codingl2k1
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #735

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #736 (51bfe12) into main (771858d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files        1026     1026           
  Lines       79548    79549    +1     
  Branches    16488    16487    -1     
=======================================
+ Hits        74412    74416    +4     
+ Misses       3453     3449    -4     
- Partials     1683     1684    +1     
Flag Coverage Δ
unittests 93.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hon/xorbits/_mars/dataframe/datasource/read_csv.py 84.82% <100.00%> (+0.96%) ⬆️

... and 12 files with indirect coverage changes

@codingl2k1 codingl2k1 changed the title Fix read_csv with index_col BUG: Fix read_csv with index_col Oct 8, 2023
@XprobeBot XprobeBot added the bug Something isn't working label Oct 8, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 936c82b into xorbitsai:main Oct 9, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_csv Indexing to a list of numbers is not supported.
3 participants