-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: LogisticRegression.fit
has poor performance on speed
#717
Comments
After some inspection, mars-project/mars#2505 (comment) perhaps explain it, gradient based loop solution for logistic regression is inefficient for |
JiaYaobo
changed the title
BUG:
BUG: Sep 25, 2023
LogisticRegression.fit
never stops with a bit *larger* data.LogisticRegression.fit
has poor performance on speed
Maybe we should use a different approach on the control flows, like for loop. For example, the method in this paper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
LogisticRegression.fit
never stops with a bit larger data.To Reproduce
When
max_iter=1
everything works fineHowever, just increase
max_iter
to 100, the program seems never stop (at least after 1min, it's weird.)The text was updated successfully, but these errors were encountered: